Summary: | [EFL] Implementation of missing functions in GraphicsContext3DPrivate | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hyowon Kim <hw1008.kim> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, noam, ryuan.choi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 62961 | ||||||||
Bug Blocks: | 79766 | ||||||||
Attachments: |
|
Description
Hyowon Kim
2012-02-28 00:14:27 PST
Created attachment 129204 [details]
Patch
Comment on attachment 129204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review LGTM, except a couple of nitpicks - please fix before committing. > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434 > + if (m_syntheticErrors.size() > 0) { Use .isEmpty() > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463 > + *value /= 4; Comment for why this is /4 Created attachment 129380 [details]
modified patch
(In reply to comment #2) > (From update of attachment 129204 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review > LGTM, except a couple of nitpicks - please fix before committing. > > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434 > > + if (m_syntheticErrors.size() > 0) { > Use .isEmpty() > > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463 > > + *value /= 4; > Comment for why this is /4 It's a really important finding! I was a little confused about OpenGL ES 2 compliance. Evas_GL offers the OpenGL ES 2 interface, so I removed codes for desktop-GL in getIntegerv() like GraphicsContext3DOpenGLES.cpp. Please review this modification again. Thanks. Comment on attachment 129380 [details]
modified patch
LGTM, please have one of the EFL committers set the cq flag.
Comment on attachment 129380 [details] modified patch Clearing flags on attachment: 129380 Committed r109694: <http://trac.webkit.org/changeset/109694> All reviewed patches have been landed. Closing bug. |