Summary: | [ShadowDOM] Replace createDom and createShadow function in LayoutTests/fast/dom/shadow/create-dom.js with more flexible one | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||
Component: | DOM | Assignee: | Hayato Ito <hayato> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, dominicc, morrita, rolandsteiner, shinyak, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 80449 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Hayato Ito
2012-02-27 22:45:04 PST
Created attachment 129191 [details]
rewrite createDOM
Comment on attachment 129191 [details] rewrite createDOM Clearing flags on attachment: 129191 Committed r109191: <http://trac.webkit.org/changeset/109191> All reviewed patches have been landed. Closing bug. Comment on attachment 129191 [details] rewrite createDOM View in context: https://bugs.webkit.org/attachment.cgi?id=129191&action=review > LayoutTests/fast/dom/shadow/resources/create-dom.js:21 > + shadowRoot = new internals.ensureShadowRoot(element); This typo is making the tests fail on platforms that don't have SHADOW_ROOT enabled. Shouldn't have "new". Ops. My bad. I should have tested this patch on platforms which don't have SHADOW_ROOT enabled. (In reply to comment #4) > (From update of attachment 129191 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129191&action=review > > > LayoutTests/fast/dom/shadow/resources/create-dom.js:21 > > + shadowRoot = new internals.ensureShadowRoot(element); > > This typo is making the tests fail on platforms that don't have SHADOW_ROOT enabled. Shouldn't have "new". |