Bug 79742

Summary: Add missing parameter to didCreateScriptContext() so it overrides base class again.
Product: WebKit Reporter: James Kozianski <koz>
Component: New BugsAssignee: James Kozianski <koz>
Status: RESOLVED FIXED    
Severity: Normal CC: bashi, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

James Kozianski
Reported 2012-02-27 21:35:03 PST
Add missing parameter to didCreateScriptContext() so it overrides base class again.
Attachments
Patch (1.72 KB, patch)
2012-02-27 21:35 PST, James Kozianski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Kozianski
Comment 1 2012-02-27 21:35:42 PST
Created attachment 129184 [details] Patch
Kenichi Ishibashi
Comment 2 2012-02-27 21:39:59 PST
Kent-san, could you review the patch? This should fix WebFrameTest failures. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/12819/steps/webkit_unit_tests/logs/stdio
Kent Tamura
Comment 3 2012-02-27 21:45:02 PST
Comment on attachment 129184 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129184&action=review ok > Source/WebKit/chromium/ChangeLog:7 > + We had better explain that http://trac.webkit.org/changeset/109064 added the parameter.
WebKit Review Bot
Comment 4 2012-02-27 22:34:26 PST
Comment on attachment 129184 [details] Patch Clearing flags on attachment: 129184 Committed r109078: <http://trac.webkit.org/changeset/109078>
WebKit Review Bot
Comment 5 2012-02-27 22:34:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.