Bug 79723

Summary: [chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, nduca, shawnsingh, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67499, 79428    
Attachments:
Description Flags
Patch enne: review+

Description James Robinson 2012-02-27 17:31:51 PST 
[chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
Comment 1 James Robinson 2012-02-27 17:32:20 PST 
Created attachment 129147 [details]
Patch
Comment 2 Adrienne Walker 2012-03-01 10:03:41 PST 
Comment on attachment 129147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129147&action=review

Yay, thread safety.

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:-492
> -    EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(0, testLayer->setName("Test Layer"));

nit: Can you move this line to the section that makes sure it does call needsCommit rather than just removing it?
Comment 3 James Robinson 2012-03-01 16:48:09 PST 
Committed r109466: <http://trac.webkit.org/changeset/109466>
Comment 4 James Robinson 2012-03-01 16:48:58 PST 
(In reply to comment #2)
> (From update of attachment 129147 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129147&action=review
> 
> Yay, thread safety.
> 
> > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:-492
> > -    EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(0, testLayer->setName("Test Layer"));
> 
> nit: Can you move this line to the section that makes sure it does call needsCommit rather than just removing it?

Done!