Summary: | Clipboard::getData should return an empty string instead of undefined | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Cheng <dcheng> | ||||||
Component: | New Bugs | Assignee: | Daniel Cheng <dcheng> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, japhet, ojan, rakuco, tony, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Daniel Cheng
2012-02-27 16:10:38 PST
Created attachment 129126 [details]
Patch
Are we planning on importing more IETC tests? This is covered by http://samples.msdn.microsoft.com/ietestcenter/html5/dragdrop/getData_dragenter.htm. Otherwise I'll just write a new layout test for this. You can either import the IETC test or write a new test. Whatever is more convenient for you. In the past I've found it easier to write a new test. Most of the IETC tests are not designed for automated testing. Comment on attachment 129126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129126&action=review > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) This will cause the CQ to fail, you'll need to replace this line with a list of tests your'e changing/adding. Created attachment 129149 [details]
Patch
Comment on attachment 129149 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129149&action=review It seems unfortunate that you can't tell if something is in the clipboard or just an empty string, but maybe that's intentional. What does Firefox do? > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452 > + if (!getWebLocData(dataObject, url, title)) { Nit: Can we early return here instead of nesting? (In reply to comment #7) > (From update of attachment 129149 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129149&action=review > > It seems unfortunate that you can't tell if something is in the clipboard or just an empty string, but maybe that's intentional. > > What does Firefox do? > My test shows they return empty strings instead of undefined. > > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452 > > + if (!getWebLocData(dataObject, url, title)) { > > Nit: Can we early return here instead of nesting? Done. Committed r109176: <http://trac.webkit.org/changeset/109176> |