Bug 79697 – Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Klein]

Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate

[Adam Klein]

Created attachment 129097 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 129097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129097&action=review

> Source/WebCore/dom/ContainerNode.cpp:817
>      for (Node* child = m_firstChild; child; child = child->nextSibling())
> -        child->insertedIntoTree(true);
> +        if (child->isContainerNode())
> +            toContainerNode(child)->insertedIntoTree(true);

Nit: this for loop needs curly brackets now.

> Source/WebCore/dom/ContainerNode.cpp:826
>      for (Node* child = m_firstChild; child; child = child->nextSibling())
> -        child->removedFromTree(true);
> +        if (child->isContainerNode())
> +            toContainerNode(child)->removedFromTree(true);

Ditto.

> Source/WebCore/dom/ContainerNode.h:91
> +    virtual void insertedIntoTree(bool deep);
> +    virtual void removedFromTree(bool deep);

We should change these to enums (of course in a separate patch) :(

[Adam Klein]

Committed r109026: <http://trac.webkit.org/changeset/109026>