Bug 79690

Summary: Cleanup Gesture requirement when exiting video-play-require-user-gesture test
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Min Qin
Reported 2012-02-27 11:56:08 PST
Cleanup Gesture requirement when exiting video-play-require-user-gesture test
Attachments
Patch (2.39 KB, patch)
2012-02-27 11:56 PST, Min Qin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2012-02-27 11:56:47 PST
Created attachment 129079 [details] Patch
Philippe Normand
Comment 2 2012-02-27 12:06:56 PST
Is this the cause of the flakiness? I didn't check your whole patch introducing this test, it was just a hunch I had.
Min Qin
Comment 3 2012-02-27 12:10:22 PST
Seems so, tested it with chromium. The chromium bot sometimes got 1-2 flaky test with my test html. But with this change, the flakiness is gone.
Philippe Normand
Comment 4 2012-02-27 12:19:54 PST
Comment on attachment 129079 [details] Patch Looks good, thanks!
WebKit Review Bot
Comment 5 2012-02-27 13:11:09 PST
Comment on attachment 129079 [details] Patch Clearing flags on attachment: 129079 Committed r109018: <http://trac.webkit.org/changeset/109018>
WebKit Review Bot
Comment 6 2012-02-27 13:11:14 PST
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 7 2012-02-27 13:54:57 PST
Media flakiness indeed went away thanks to this patch. Thanks :)
Min Qin
Comment 8 2012-02-27 14:11:15 PST
Thank you for finding out this problem, and for your hunch!
Note You need to log in before you can comment on or make changes to this bug.