Summary: | Lexer: Specialize character predicates for LChar, UChar | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Wingo <wingo> | ||||||
Component: | JavaScriptCore | Assignee: | Andy Wingo <wingo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, ggaren, msaboff, oliver, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andy Wingo
2012-02-27 09:22:02 PST
Created attachment 129055 [details]
Patch
Adding reviewers. For speed tests, I used this: $ time echo 'for (var i=0; i<1000; i++) checkSyntax("tests/parse-only/concat-jquery-mootools-prototype.js");' | /home/wingo/src/WebKit-trunk/WebKitBuild/Release/Programs/.libs/lt-jsc-3 /dev/stdin real 0m6.290s user 0m6.000s sys 0m0.256s $ time echo 'for (var i=0; i<1000; i++) checkSyntax("tests/parse-only/concat-jquery-mootools-prototype.js");' | /home/wingo/src/WebKit/WebKitBuild/Release/Programs/.libs/lt-jsc-3 /dev/stdin real 0m6.141s user 0m5.936s sys 0m0.180s That is to say, that I ran checkSyntax 1000 times in the same process on the larger file in the parse-only tests, and timed the whole run. Here we see a reduction from 6.29 total seconds to 6.14 total seconds. The times vary a bit, but they're about like this. Created attachment 130089 [details]
fix unused param warning on mac
Comment on attachment 130089 [details]
fix unused param warning on mac
r=me
Comment on attachment 130089 [details]
fix unused param warning on mac
Thanks!
Comment on attachment 130089 [details] fix unused param warning on mac Clearing flags on attachment: 130089 Committed r109769: <http://trac.webkit.org/changeset/109769> All reviewed patches have been landed. Closing bug. |