Bug 79667 – [GTK] Add method webkit_web_resource_get_data() to WebKit2 GTK+ API

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

And webkit_web_resource_get_data_finish() to finish the async operation.

[Carlos Garcia Campos]

Created attachment 129029 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 129029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129029&action=review

+1

> Source/WebKit2/UIProcess/API/gtk/WebKitWebResource.cpp:346
> + *    of error. Set @length to a #gsize to get the length of the string.

I'd say 'if @length is not %NULL, the size of the data will be assigned to it', also, I would avoid using 'string' in any of these, because they are often not strings.

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 129029 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129029&action=review
> 
> +1
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebResource.cpp:346
> > + *    of error. Set @length to a #gsize to get the length of the string.
> 
> I'd say 'if @length is not %NULL, the size of the data will be assigned to it', also, I would avoid using 'string' in any of these, because they are often not strings.

Indeed, I really meant the data not the string :-P

[Carlos Garcia Campos]

I haven't landed this yet, because it depends on bug #79477, a review would be appreciated :-)

[Carlos Garcia Campos]

Committed r112227: <http://trac.webkit.org/changeset/112227>