Bug 79646

Summary: [EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, mpakulavelrutka, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Grzegorz Czajkowski
Reported 2012-02-27 01:34:53 PST
INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake). As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction with Ewk_Context_Menu_Action. To avoid similar case in the feature I added checks between WebCore and WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.
Attachments
proposed patch (10.57 KB, patch)
2012-02-27 01:36 PST, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2012-02-27 01:36:01 PST
Created attachment 128984 [details] proposed patch
Grzegorz Czajkowski
Comment 2 2012-02-27 03:54:10 PST
CC'ing Ryuan and Michał.
Andreas Kling
Comment 3 2012-03-01 06:51:24 PST
Comment on attachment 128984 [details] proposed patch rs=me
WebKit Review Bot
Comment 4 2012-03-02 00:34:11 PST
Comment on attachment 128984 [details] proposed patch Clearing flags on attachment: 128984 Committed r109524: <http://trac.webkit.org/changeset/109524>
WebKit Review Bot
Comment 5 2012-03-02 00:34:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.