Summary: | [Refactoring] RenderSummary and RenderDetail is no longer needed. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||||||
Component: | Layout and Rendering | Assignee: | Hajime Morrita <morrita> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | rakuco, shinyak, tkent, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Hajime Morrita
2012-02-27 00:52:26 PST
Created attachment 129196 [details]
Patch
Kent-san, could you take a look? They're finally gone. Comment on attachment 129196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129196&action=review > Source/WebCore/rendering/RenderDetailsMarker.cpp:147 > + ASSERT(false); Does this mean ASSERT_NOT_REACHED()? > Does this mean ASSERT_NOT_REACHED()?
Oops. It's for debug. I should remove it.
Created attachment 129202 [details]
Patch
Comment on attachment 129202 [details]
Patch
Looks ok
Created attachment 129215 [details]
Patch for landing
Comment on attachment 129215 [details] Patch for landing Rejecting attachment 129215 [details] from commit-queue. New failing tests: fullscreen/full-screen-render-inline.html Full output: http://queues.webkit.org/results/11666064 Created attachment 129360 [details]
Patch for landing
Comment on attachment 129360 [details] Patch for landing Rejecting attachment 129360 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 10840 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 10840. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11682071 Committed r109192: <http://trac.webkit.org/changeset/109192> |