Bug 79629

Summary: Color input type should be clickable through keyboard
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2012-02-26 23:10:09 PST
Pressing space/return keys should trigger a click on a focused color input element.
Attachments
Patch (24.43 KB, patch)
2012-02-26 23:20 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (24.78 KB, patch)
2012-02-26 23:50 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-02-26 23:20:12 PST
Created attachment 128963 [details] Patch
Kent Tamura
Comment 2 2012-02-26 23:36:04 PST
Comment on attachment 128963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128963&action=review > Source/WebCore/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp Please summarize the code change. e.g. Introduce BaseClickableWithKeyInputType, and ColorInputType inherits it because .... > Source/WebCore/html/BaseClickableWithKeyInputType.cpp:3 > + * Copyright (C) 2012 Google Inc. All rights reserved. > + * This file contains the code of BaseButtonInpuType.cpp. You have to respect the copyright notice of the original BaseButtonInputType.cpp.
Keishi Hattori
Comment 3 2012-02-26 23:50:12 PST
Created attachment 128969 [details] Patch
Keishi Hattori
Comment 4 2012-02-26 23:51:01 PST
Comment on attachment 128963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128963&action=review >> Source/WebCore/ChangeLog:8 >> + * CMakeLists.txt: Added BaseClickableWithKeyInputType.cpp > > Please summarize the code change. > e.g. Introduce BaseClickableWithKeyInputType, and ColorInputType inherits it because .... Done. >> Source/WebCore/html/BaseClickableWithKeyInputType.cpp:3 >> + * > > This file contains the code of BaseButtonInpuType.cpp. You have to respect the copyright notice of the original BaseButtonInputType.cpp. Done.
Kent Tamura
Comment 5 2012-02-26 23:56:40 PST
Comment on attachment 128969 [details] Patch ok
WebKit Review Bot
Comment 6 2012-02-27 02:23:40 PST
Comment on attachment 128969 [details] Patch Clearing flags on attachment: 128969 Committed r108976: <http://trac.webkit.org/changeset/108976>
WebKit Review Bot
Comment 7 2012-02-27 02:23:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.