Bug 79624

Summary:

Extract Supplementable base class from Page and Navigator

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79327

Attachments:

Description	Flags
Patch	morrita: review+, gyuyoung.kim: commit-queue-

Description Adam Barth 2012-02-26 22:07:28 PST

Extract Supplementable base class from Page and Navigator

Comment 1 Adam Barth 2012-02-26 22:08:40 PST

Created attachment 128951 [details]
Patch

Comment 2 Hajime Morrita 2012-02-26 22:19:09 PST

Comment on attachment 128951 [details]
Patch

r=me assuming green bots.
Maybe typedef-ing NavigatorSupplement and PageSupplement will help to minimize the diff and
introducing future subclasses like NavigatorSupplement : public Supplement<Navigator> {};

Comment 3 Adam Barth 2012-02-26 22:20:38 PST

I was kind of hoping we could avoid having typedefs or new subclasses.  It would certainly make the diff smaller though...

Comment 4 Adam Barth 2012-02-26 22:20:45 PST

Thanks for the review.

Comment 5 Gyuyoung Kim 2012-02-26 22:23:39 PST

Comment on attachment 128951 [details]
Patch

Attachment 128951 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11633768

Comment 6 Adam Barth 2012-02-26 22:33:52 PST

Committed r108958: <http://trac.webkit.org/changeset/108958>