Bug 79600

Summary: Implement the basis of KURLWTFURL
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: PlatformAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Benjamin Poulain
Reported 2012-02-25 23:42:51 PST
Make a not-optimized, working KURL based on WTFURL.
Attachments
Patch (10.65 KB, patch)
2012-02-25 23:52 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (15.17 KB, patch)
2012-03-03 16:37 PST, Benjamin Poulain 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-02-25 23:52:17 PST
Created attachment 128907 [details] Patch Partial Implementation, no time to finish today
Benjamin Poulain
Comment 2 2012-03-03 16:37:00 PST
Created attachment 130010 [details] Patch
Adam Barth
Comment 3 2012-03-03 17:05:48 PST
Comment on attachment 130010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130010&action=review > Source/WebCore/platform/KURLWTFURL.cpp:103 > + DEFINE_STATIC_LOCAL(const String, nullString, ()); This shouldn't really be needed. A null string is just a value type anyway. > Source/WebCore/platform/KURLWTFURL.cpp:219 > + return WebCore::protocolIs(protocol(), testProtocol); Part of the point of this function is to avoid the malloc. This implementation keeps the malloc...
Benjamin Poulain
Comment 4 2012-03-03 17:13:33 PST
> > Source/WebCore/platform/KURLWTFURL.cpp:103 > > + DEFINE_STATIC_LOCAL(const String, nullString, ()); > > This shouldn't really be needed. A null string is just a value type anyway. The trouble is this function return a reference (for now) :( > > Source/WebCore/platform/KURLWTFURL.cpp:219 > > + return WebCore::protocolIs(protocol(), testProtocol); > > Part of the point of this function is to avoid the malloc. This implementation keeps the malloc... This is the case for many functions here (all the hasFooBar() for example). I just went for the easiest implementation and will optimize later. Thanks for the review Adam.
Benjamin Poulain
Comment 5 2012-03-03 19:49:30 PST
Committed r109671: <http://trac.webkit.org/changeset/109671>
Note You need to log in before you can comment on or make changes to this bug.