Bug 79550

Summary: Add media control css for chromium on android
Product: WebKit Reporter: Min Qin <qinmin>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Min Qin
Reported 2012-02-24 18:58:49 PST
Add media control css for chromium on android
Attachments
Patch (12.08 KB, patch)
2012-02-24 19:03 PST, Min Qin 		no flags
DetailsFormatted DiffDiff
Patch (12.10 KB, patch)
2012-02-27 11:28 PST, Min Qin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Min Qin
Comment 1 2012-02-24 19:03:53 PST
Created attachment 128838 [details] Patch
Adam Barth
Comment 2 2012-02-25 21:55:21 PST
Comment on attachment 128838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128838&action=review > Source/WebCore/rendering/RenderMediaControlsChromium.cpp:247 > + static Image* mediaFullscreen = platformResource("mediaFullscreen"); Please use the DEFINE_STATIC_LOCAL macro.
Min Qin
Comment 3 2012-02-27 11:28:12 PST
Created attachment 129076 [details] Patch
Min Qin
Comment 4 2012-02-27 11:28:37 PST
Done. switched to use DEFINE_STATIC_LOCAL
Min Qin
Comment 5 2012-03-05 09:10:32 PST
ping. Is this change good to go now? Thanks Min
Adam Barth
Comment 6 2012-03-05 10:12:02 PST
Comment on attachment 129076 [details] Patch Yes, sorry. Please feel free to ping me if it looks like I've forgotten something.
Min Qin
Comment 7 2012-03-05 10:28:23 PST
Thank you, Adam.
WebKit Review Bot
Comment 8 2012-03-05 11:38:19 PST
Comment on attachment 129076 [details] Patch Clearing flags on attachment: 129076 Committed r109776: <http://trac.webkit.org/changeset/109776>
WebKit Review Bot
Comment 9 2012-03-05 11:38:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.