Summary: | Add media control css for chromium on android | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Min Qin <qinmin> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, macpherson, menard, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Min Qin
2012-02-24 18:58:49 PST
Created attachment 128838 [details]
Patch
Comment on attachment 128838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128838&action=review > Source/WebCore/rendering/RenderMediaControlsChromium.cpp:247 > + static Image* mediaFullscreen = platformResource("mediaFullscreen"); Please use the DEFINE_STATIC_LOCAL macro. Created attachment 129076 [details]
Patch
Done. switched to use DEFINE_STATIC_LOCAL ping. Is this change good to go now? Thanks Min Comment on attachment 129076 [details]
Patch
Yes, sorry. Please feel free to ping me if it looks like I've forgotten something.
Thank you, Adam. Comment on attachment 129076 [details] Patch Clearing flags on attachment: 129076 Committed r109776: <http://trac.webkit.org/changeset/109776> All reviewed patches have been landed. Closing bug. |