Summary: | [chromium] Provide DefaultDeviceScaleFactor though WebSettings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Dresser <tdresser> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, darin, ddkilzer, fishd, fsamuel, joepeck, rjkroege, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Tim Dresser
2012-02-24 14:52:03 PST
Created attachment 128816 [details]
Patch
What does NOT FOR REVIEW in the bug title mean? Shouldn't it be on patch name instead? Comment on attachment 128816 [details]
Patch
Looks reasonable to me.
It's not clear to me that deviceScaleFactor should be affected by viewport tag settings. Would it change as the user zooms? My apologies for the spam. I asked Tim to ask Darin, meaning fishd@ but he obediently added darin@ to the CC list. smfr@: in chromium, the viewport tag lets a web page author specify the devicePixelRatio of the page. However, we want the popup portion of <select> tags to obey the default device scale factor -- not a device scale factor modified by the viewport tag of the initiating page. Hence the additional integer parameter. fishd@: could you take a look at this CL? Comment on attachment 128816 [details] Patch Clearing flags on attachment: 128816 Committed r109155: <http://trac.webkit.org/changeset/109155> All reviewed patches have been landed. Closing bug. |