Bug 79534

Summary: [chromium] Provide DefaultDeviceScaleFactor though WebSettings
Product: WebKit Reporter: Tim Dresser <tdresser>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, ddkilzer, fishd, fsamuel, joepeck, rjkroege, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Tim Dresser
Reported 2012-02-24 14:52:03 PST
DefaultDeviceScaleFactor will be based solely on the screen DPI, as opposed to DeviceScaleFactor, which incorporates information from the viewport tag.
Attachments
Patch (5.78 KB, patch)
2012-02-24 15:02 PST, Tim Dresser 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Dresser
Comment 1 2012-02-24 15:02:39 PST
Created attachment 128816 [details] Patch
Alexey Proskuryakov
Comment 2 2012-02-24 16:54:00 PST
What does NOT FOR REVIEW in the bug title mean? Shouldn't it be on patch name instead?
Robert Kroeger
Comment 3 2012-02-27 07:06:50 PST
Comment on attachment 128816 [details] Patch Looks reasonable to me.
Simon Fraser (smfr)
Comment 4 2012-02-27 09:54:36 PST
It's not clear to me that deviceScaleFactor should be affected by viewport tag settings. Would it change as the user zooms?
Robert Kroeger
Comment 5 2012-02-27 10:49:09 PST
My apologies for the spam. I asked Tim to ask Darin, meaning fishd@ but he obediently added darin@ to the CC list. smfr@: in chromium, the viewport tag lets a web page author specify the devicePixelRatio of the page. However, we want the popup portion of <select> tags to obey the default device scale factor -- not a device scale factor modified by the viewport tag of the initiating page. Hence the additional integer parameter. fishd@: could you take a look at this CL?
WebKit Review Bot
Comment 6 2012-02-28 15:05:39 PST
Comment on attachment 128816 [details] Patch Clearing flags on attachment: 128816 Committed r109155: <http://trac.webkit.org/changeset/109155>
WebKit Review Bot
Comment 7 2012-02-28 15:05:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.