Bug 79505

Summary:

Flaky Test: fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html

Product:

WebKit

Reporter:

WebKit Review Bot <webkit.review.bot>

Component:

Tools / Tests

Assignee:

WebKit Review Bot <webkit.review.bot>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, enne, japhet

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

50856

Attachments:

Description	Flags
Patch	dbates: review+

Description WebKit Review Bot 2012-02-24 10:02:32 PST

This is an automatically generated bug from the commit-queue.
fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html has been flaky on the commit-queue.

fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html was authored by dbates@webkit.org.
http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html

The commit-queue just saw fast/dom/HTMLLinkElement/link-onerror-stylesheet-with-existent-and-non-existent-import.html flake (Text diff mismatch) while processing attachment 128535 [details] on bug 79388.
Bot: ec2-cq-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.

Comment 1 Adrienne Walker 2012-02-24 11:36:30 PST

It looks like there's some sort of timing issue between when script executes to set the layoutTestController dumpResourceResponesMIMETypes flag and when the stylesheet response is received.  On Chromium, even if I put Javascript directly in the test HTML to set this flag, it still doesn't occur in time.

The right answer might be to remove this flag from link-load-utilities, and then rebaseline all tests that use it.

Comment 2 Adrienne Walker 2012-02-24 12:45:31 PST

Created attachment 128784 [details]
Patch

Comment 3 Daniel Bates 2012-02-24 12:46:37 PST

Comment on attachment 128784 [details]
Patch

Thanks for the patch!

r=me

Comment 4 Adrienne Walker 2012-02-24 13:06:44 PST

Committed r108839: <http://trac.webkit.org/changeset/108839>