Bug 79501

Summary: [Qt][WK2] Get rid of the #ifdef mess in LayerTreeHost[Proxy]
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, menard, webkit.review.bot, yael, zoltan
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
noam: commit-queue+
Patch none

Noam Rosenthal
Reported 2012-02-24 09:43:57 PST
We use a wide set of #ifdefs to encapsulate the LayerTreeHostProxy implemetation, and to encapsulate the TILED_BACKING_STORE parts of it. Instead, we should use a single guard (maybe USE(COMPOSITING_IN_UI_PROCESS) and remove the TILED_BACKING_STORE guard.
Attachments
Patch (20.80 KB, patch)
2012-02-27 09:09 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (20.88 KB, patch)
2012-02-29 10:04 PST, Noam Rosenthal 		noam: commit-queue+
DetailsFormatted DiffDiff
Patch (20.73 KB, patch)
2012-02-29 13:36 PST, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-02-27 09:09:16 PST
Created attachment 129048 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-02-29 06:53:40 PST
I don't think this is clear enough. It sounds as if is for enabling the code on the UI process, but not doing the actual compositing there. What about WTF_USE_UI_SIDE_COMPOSITING ? WTF_CLIENT_SIDE_COMPOSITING
Noam Rosenthal
Comment 3 2012-02-29 10:04:51 PST
Created attachment 129466 [details] Patch
Noam Rosenthal
Comment 4 2012-02-29 13:36:47 PST
Created attachment 129507 [details] Patch
WebKit Review Bot
Comment 5 2012-02-29 20:22:57 PST
Comment on attachment 129507 [details] Patch Clearing flags on attachment: 129507 Committed r109302: <http://trac.webkit.org/changeset/109302>
WebKit Review Bot
Comment 6 2012-02-29 20:23:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.