| Summary: | [Qt] API: Unify the loading properties and signals. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jocelyn Turcotte <jturcotte> | ||||
| Component: | New Bugs | Assignee: | Jocelyn Turcotte <jturcotte> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, hausmann, menard, vestbo, zalan, zoltan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 74403 | ||||||
| Attachments: |
|
||||||
|
Description
Jocelyn Turcotte
2012-02-24 06:35:44 PST
Created attachment 128725 [details]
Patch
Comment on attachment 128725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128725&action=review r=me. The only iffy thing that I think can be easily fixed if it actually turns out to be a problem (I'm not sure it is), is that the argument to the loadingChanged signal is very short-lived. This isn't quite specific to this patch, but perhaps we should consider using actual JavaScript objects as parameters (QJSValue) with according properties. (or JSON if you want so :) > Source/WebKit2/UIProcess/API/qt/qwebloadrequest_p.h:47 > + QWebLoadRequestPrivate* d; As a general rule perhaps we should consider adopting the Qt rule of using QScopedPointer for the d-pointer. Committed r108815: <http://trac.webkit.org/changeset/108815> |