Bug 79465

Summary: Tests for showModalDialog need to ask for permission to open windows
Product: WebKit Reporter: jochen
Component: Tools / TestsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: ap, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

jochen
Reported 2012-02-24 01:53:12 PST
Fix fast/events/scroll-event-during-modal-dialog.html so it actually displays a modal dialog
Attachments
Patch (2.04 KB, patch)
2012-02-24 02:04 PST, jochen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-02-24 02:03:43 PST
affects fast/animation/request-animation-frame-during-modal.html as well
jochen
Comment 2 2012-02-24 02:04:22 PST
Created attachment 128692 [details] Patch
WebKit Review Bot
Comment 3 2012-02-24 06:08:55 PST
Comment on attachment 128692 [details] Patch Clearing flags on attachment: 128692 Committed r108783: <http://trac.webkit.org/changeset/108783>
WebKit Review Bot
Comment 4 2012-02-24 06:09:01 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2012-02-24 13:59:59 PST
Why? Does popup blocker affect modal dialogs?
jochen
Comment 6 2012-02-24 14:02:44 PST
(In reply to comment #5) > Why? Does popup blocker affect modal dialogs? yes (at least on chromium)
Note You need to log in before you can comment on or make changes to this bug.