| Summary: | Update .gitignore for project property files generated by Eclipse. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Changwan Hong <cwhong893> | ||||
| Component: | New Bugs | Assignee: | Changwan Hong <cwhong893> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | hausmann, kling, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Changwan Hong
2012-02-24 01:34:44 PST
Created attachment 128683 [details]
Patch
Comment on attachment 128683 [details] Patch Rejecting attachment 128683 [details] from review queue. jourmoon@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 128683 [details] Patch Rejecting attachment 128683 [details] from commit-queue. jourmoon@company100.net does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 128683 [details] Patch Rejecting attachment 128683 [details] from review queue. jourmoon@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 128683 [details] Patch Rejecting attachment 128683 [details] from commit-queue. jourmoon@company100.net does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 128683 [details]
Patch
Clearing review since the bot seems to have gone roque on it :). If you want to mark a patch for review, set r? (and cq? if you want it to go through commit queue).
Comment on attachment 128683 [details]
Patch
Seems harmless. rs=me
Comment on attachment 128683 [details] Patch Clearing flags on attachment: 128683 Committed r108953: <http://trac.webkit.org/changeset/108953> All reviewed patches have been landed. Closing bug. |