Bug 79442

Summary: Move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore Misc.Assignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, commit-queue, ojan, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch
none
patch for landing none

Description Kentaro Hara 2012-02-23 21:53:01 PST
For WebKit modularization, we can move Worker-related APIs from DOMWindow.idl to DOMWindowWorker.idl.
Comment 1 Kentaro Hara 2012-02-23 21:55:33 PST
Created attachment 128650 [details]
Patch
Comment 2 Adam Barth 2012-02-23 23:03:04 PST
Comment on attachment 128650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128650&action=review

> Source/WebCore/workers/DOMWindowWorker.idl:31
> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS
> +        attribute WorkerConstructor Worker; // Usable with the new operator
> +#endif
> +
> +#if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS
> +        attribute [JSCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator
> +#endif

Can we use Conditional here?  It's prettier.
Comment 3 Kentaro Hara 2012-02-24 01:41:32 PST
Created attachment 128685 [details]
patch for landing
Comment 4 Kentaro Hara 2012-02-24 01:42:12 PST
(In reply to comment #2)
> Can we use Conditional here?  It's prettier.

Done.
Comment 5 WebKit Review Bot 2012-02-24 05:33:06 PST
Comment on attachment 128685 [details]
patch for landing

Clearing flags on attachment: 128685

Committed r108778: <http://trac.webkit.org/changeset/108778>