Bug 79434

Summary: Move XML-related APIs from DOMWindow.idl to DOMWindowXML.idl
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore Misc.Assignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, arv, commit-queue, ojan, rakuco, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79327    
Attachments:
Description Flags
Patch
none
patch for landing none

Kentaro Hara
Reported 2012-02-23 20:33:47 PST
For WebKit modularization, we can move XML-related APIs from DOMWindow.idl to DOMWIndowXML.idl.
Attachments
Patch (9.43 KB, patch)
2012-02-23 20:35 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (9.50 KB, patch)
2012-02-24 04:33 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-23 20:35:54 PST
Created attachment 128641 [details] Patch
WebKit Review Bot
Comment 2 2012-02-24 03:58:16 PST
Comment on attachment 128641 [details] Patch Rejecting attachment 128641 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Hunk #2 succeeded at 20011 (offset 2 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file Source/WebCore/page/DOMWindow.idl Hunk #1 succeeded at 437 (offset -8 lines). Hunk #2 succeeded at 466 (offset -8 lines). patching file Source/WebCore/xml/DOMWindowXML.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11608957
Kentaro Hara
Comment 3 2012-02-24 04:33:54 PST
Created attachment 128707 [details] patch for landing
WebKit Review Bot
Comment 4 2012-02-24 06:37:20 PST
Comment on attachment 128707 [details] patch for landing Clearing flags on attachment: 128707 Committed r108787: <http://trac.webkit.org/changeset/108787>
Note You need to log in before you can comment on or make changes to this bug.