Bug 79425

Summary: [chromium] Move Web*Layer* headers into Platform
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, danakj, enne, fishd, nduca, piman, shawnsingh, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79428    
Attachments:
Description Flags
Patch
abarth: review+
Patch none

James Robinson
Reported 2012-02-23 17:31:19 PST
[chromium] Move Web*Layer* headers into Platform
Attachments
Patch (76.11 KB, patch)
2012-02-23 17:33 PST, James Robinson 		abarth: review+
DetailsFormatted DiffDiff
Patch (14.70 KB, text/plain)
2012-02-24 04:31 PST, Andrey Kosyakov 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-02-23 17:33:22 PST
Created attachment 128616 [details] Patch
James Robinson
Comment 2 2012-02-23 17:35:11 PST
This moves Web*Layer* headers over to Platform so that I can start depending on these inside WebCore. This will conflict with the changes to WebLayerTreeView in https://bugs.webkit.org/show_bug.cgi?id=75591, after I land whichever one I can get a review on first I'll take care of the conflicts to the other patch.
WebKit Commit Bot
Comment 3 2012-02-24 02:16:28 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
WebKit Commit Bot
Comment 4 2012-02-24 02:16:37 PST
Attachment 128616 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/Platform/chromium/public/WebPrivatePtr.h:42: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/Platform/chromium/public/WebColorName.h:69: One space before end of line comments [whitespace/comments] [5] Source/Platform/chromium/public/WebColor.h:39: One space before end of line comments [whitespace/comments] [5] Total errors found: 3 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrey Kosyakov
Comment 5 2012-02-24 04:31:59 PST
Created attachment 128706 [details] Patch
Andrey Kosyakov
Comment 6 2012-02-24 04:36:15 PST
Comment on attachment 128706 [details] Patch Please disregard my attachment, uploaded to a wrong bug, sorry!
James Robinson
Comment 7 2012-02-24 11:29:06 PST
Committed r108829: <http://trac.webkit.org/changeset/108829>
Note You need to log in before you can comment on or make changes to this bug.