Bug 79371

Summary: [CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, mxie, rakuco, rwlbuis, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+, dbates: commit-queue-

Patrick R. Gansterer
Reported 2012-02-23 09:45:17 PST
[CMake] Add WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS macro
Attachments
Patch (47.93 KB, patch)
2012-02-23 09:50 PST, Patrick R. Gansterer 		dbates: review+
dbates: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-02-23 09:50:15 PST
Created attachment 128490 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-02-23 10:25:31 PST
Looks sane to me.
Daniel Bates
Comment 3 2012-02-23 11:00:48 PST
Comment on attachment 128490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128490&action=review > ChangeLog:8 > + Add a new macro to handle the inclusion of the platform specifc *.cmake files. Nit: specifc => specific > ChangeLog:9 > + In the future this macro should get expanded to handle also feature specifc I think it would read better if you change "handle also" to "also handle" or "handle". Also, specifc => specific.
Patrick R. Gansterer
Comment 4 2012-02-23 11:23:46 PST
Committed r108648: <http://trac.webkit.org/changeset/108648>
Note You need to log in before you can comment on or make changes to this bug.