Summary: | Support [Supplemental] on static methods | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, japhet, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-02-23 04:04:48 PST
Created attachment 128453 [details]
Patch
This fix is needed for making DOMURLMediaStream.idl. Comment on attachment 128453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128453&action=review > Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:155 > +static v8::Handle<v8::Value> supplementalMethod4Callback(const v8::Arguments& args) > +{ > + INC_STATS("DOM.TestInterface.supplementalMethod4"); > + TestSupplemental::supplementalMethod4(imp); > + return v8::Handle<v8::Value>(); > +} How does this build? There's no imp declared in this function. Created attachment 128601 [details]
patch for landing
Comment on attachment 128601 [details] patch for landing > How does this build? There's no imp declared in this function. Fixed it. Thanks. The run-bindings-tests results for ObjC, GObject and CPP are wrong, but it is OK since they do not yet support static methods. Comment on attachment 128601 [details] patch for landing Clearing flags on attachment: 128601 Committed r108757: <http://trac.webkit.org/changeset/108757> |