Bug 7935

Summary:

Infinite recursion in table code when button or new text fields get display:table-row

Product:

WebKit

Reporter:

Adele Peterson <adele>

Component:

Tables

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, hyatt

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch	none
better patch and Changelog	none

Adele Peterson

Reported 2006-03-23 10:56:24 PST

<input type="button" style="display: table-row;" value="test"> causes infinite recursion.

Attachments
patch (520 bytes, patch) 2006-03-23 11:05 PST, Adele Peterson	no flags	Details Formatted Diff Diff
better patch and Changelog (1.97 KB, patch) 2006-03-23 12:01 PST, Adele Peterson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adele Peterson

Comment 1 2006-03-23 10:56:55 PST

I'm testing a fix for this.

Adele Peterson

Comment 2 2006-03-23 11:05:49 PST

Created attachment 7253 [details] patch

Adele Peterson

Comment 3 2006-03-23 11:13:13 PST

Hyatt was saying that maybe we just shouldn't allow this style to be set on form elements at all.

Adele Peterson

Comment 4 2006-03-23 11:27:43 PST

Here's the repeating bt: #20 0x01f91260 in WebCore::RenderBlock::addChildToFlow (this=0x1347391c, newChild=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderBlock.cpp:201 #21 0x01fbce98 in WebCore::RenderFlow::addChild (this=0x1347391c, newChild=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderFlow.cpp:120 #22 0x020235ac in WebCore::RenderTableRow::addChild (this=0x134737fc, child=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderTableRow.cpp:89 #23 0x02022e68 in WebCore::RenderTableSection::addChild (this=0x134736fc, child=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderTableSection.cpp:112 #24 0x0201b220 in WebCore::RenderTable::addChild (this=0x1347354c, child=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderTable.cpp:185 #25 0x01fb6d3c in WebCore::RenderContainer::addChild (this=0x1347342c, newChild=0x1125b68c, beforeChild=0x0) at /Volumes/Data/adelep/Source/TOT/Labyrinth/OpenSource/WebCore/rendering/RenderContainer.cpp:154

Adele Peterson

Comment 5 2006-03-23 12:01:31 PST

Created attachment 7257 [details] better patch and Changelog

Adele Peterson

Comment 6 2006-03-23 13:21:32 PST

Comment on attachment 7257 [details] better patch and Changelog hyatt and i discussed a different approach for this.

Note You need to log in before you can comment on or make changes to this bug.