Summary: | SpellCheckRequest needs to know the context where the spellcheck happened | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||||||||||||||||||||||
Component: | HTML Editing | Assignee: | Shinya Kawanaka <shinyak> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, gustavo, hbono, japhet, pnormand, rakuco, shinyak, webkit.review.bot, xan.lopez | ||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
Attachments: |
|
Description
Hajime Morrita
2012-02-22 20:19:10 PST
Created attachment 128383 [details]
WIP
Comment on attachment 128383 [details] WIP Attachment 128383 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11600107 Comment on attachment 128383 [details] WIP Attachment 128383 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11603093 Comment on attachment 128383 [details] WIP Attachment 128383 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11602095 Created attachment 128387 [details]
WIP
Created attachment 128388 [details]
WIP
Created attachment 128391 [details]
WIP
Created attachment 128396 [details]
Patch
Comment on attachment 128396 [details] Patch Attachment 128396 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11610106 Created attachment 128410 [details]
Patch
Comment on attachment 128410 [details] Patch Attachment 128410 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11610126 Created attachment 128415 [details]
Patch
Comment on attachment 128415 [details] Patch Attachment 128415 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11602131 Created attachment 128417 [details]
Patch
Created attachment 128418 [details]
Patch
Comment on attachment 128418 [details]
Patch
Let me see the green bots.
Comment on attachment 128418 [details] Patch Attachment 128418 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11600191 New failing tests: editing/spelling/spellcheck-async.html editing/spelling/spellcheck-async-mutation.html editing/spelling/spelling-marker-description.html editing/spelling/grammar-paste.html editing/spelling/spellcheck-paste.html editing/spelling/spellcheck-sequencenum.html editing/spelling/spellcheck-queue.html Created attachment 128430 [details]
Patch
(In reply to comment #17) > (From update of attachment 128418 [details]) > Attachment 128418 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11600191 > > New failing tests: > editing/spelling/spellcheck-async.html > editing/spelling/spellcheck-async-mutation.html > editing/spelling/spelling-marker-description.html > editing/spelling/grammar-paste.html > editing/spelling/spellcheck-paste.html > editing/spelling/spellcheck-sequencenum.html > editing/spelling/spellcheck-queue.html Ah, I've touched PassRefPtr which became null... Boo Comment on attachment 128430 [details] Patch Attachment 128430 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11600311 Created attachment 128629 [details]
Patch
mac bot seems drunk... Created attachment 128643 [details]
Patch
Comment on attachment 128643 [details] Patch Clearing flags on attachment: 128643 Committed r108772: <http://trac.webkit.org/changeset/108772> All reviewed patches have been landed. Closing bug. |