Bug 79310

Summary:

DFG OSR exit value profiling should have graceful handling of local variables and arguments

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
work in progress	none
the patch	none
the patch	webkit-ews: commit-queue-
the patch	none
the patch	barraclough: review+

Filip Pizlo

Reported 2012-02-22 17:22:48 PST

Patch forthcoming.

Attachments
work in progress (74.07 KB, patch) 2012-02-22 17:26 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (86.69 KB, patch) 2012-02-22 21:03 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (86.63 KB, patch) 2012-02-22 21:10 PST, Filip Pizlo	webkit-ews: commit-queue-	Details Formatted Diff Diff
the patch (86.67 KB, patch) 2012-02-22 23:22 PST, Filip Pizlo	no flags	Details Formatted Diff Diff
the patch (87.16 KB, patch) 2012-02-22 23:42 PST, Filip Pizlo	barraclough: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2012-02-22 17:26:17 PST

Created attachment 128345 [details] work in progress Work in progress. Backing up.

Filip Pizlo

Comment 2 2012-02-22 21:03:44 PST

Created attachment 128385 [details] the patch

Filip Pizlo

Comment 3 2012-02-22 21:10:35 PST

Created attachment 128386 [details] the patch Updated the ChangeLog.

Filip Pizlo

Comment 4 2012-02-22 21:37:34 PST

Mac build results seem to be because some of my template foo requires some compiler love. I'll fiddle with it.

Early Warning System Bot

Comment 5 2012-02-22 21:54:04 PST

Comment on attachment 128386 [details] the patch Attachment 128386 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11576125

Filip Pizlo

Comment 6 2012-02-22 23:22:43 PST

Created attachment 128405 [details] the patch Attempting to fix build.

Filip Pizlo

Comment 7 2012-02-22 23:42:59 PST

Created attachment 128411 [details] the patch More build fixing.

Gavin Barraclough

Comment 8 2012-02-23 14:32:40 PST

Comment on attachment 128411 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=128411&action=review > Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:162 > + OwnPtr<SegmentedVector<LazyOperandValueProfile, 8> > m_data; typedef for SegmentedVector<LazyOperandValueProfile, 8> wouldn't hurt. > Source/JavaScriptCore/dfg/DFGNode.h:488 > + Please revert before landing.

Filip Pizlo

Comment 9 2012-02-23 14:33:29 PST

(In reply to comment #8) > (From update of attachment 128411 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128411&action=review > > > Source/JavaScriptCore/bytecode/LazyOperandValueProfile.h:162 > > + OwnPtr<SegmentedVector<LazyOperandValueProfile, 8> > m_data; > > typedef for SegmentedVector<LazyOperandValueProfile, 8> wouldn't hurt. Good point! > > > Source/JavaScriptCore/dfg/DFGNode.h:488 > > + > > Please revert before landing. Will do. Thanks!

Filip Pizlo

Comment 10 2012-02-23 14:50:53 PST

Landed in http://trac.webkit.org/changeset/108677

Filip Pizlo

Comment 11 2012-02-23 16:41:49 PST

<rdar://problem/10923454>

Note You need to log in before you can comment on or make changes to this bug.