Bug 79307

Summary: Should remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dominicc, hayato, morrita, rolandsteiner, shinyak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77499    
Attachments:
Description Flags
Patch
none
Patch Candidate for landing none

Hajime Morrita
Reported 2012-02-22 17:03:41 PST
Once it's ready, we should remove this tentative flag.
Attachments
Patch (16.54 KB, patch)
2012-03-16 06:29 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch Candidate for landing (16.63 KB, patch)
2012-03-18 20:39 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-03-16 05:12:08 PDT
It's time to remove this flag.
Shinya Kawanaka
Comment 2 2012-03-16 06:29:53 PDT
Created attachment 132268 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2012-03-16 07:53:36 PDT
Comment on attachment 132268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132268&action=review Weee!!! > LayoutTests/fast/dom/shadow/shadow-root-js-api.html:60 > +var youngerShadowRoot = new WebKitShadowRoot(shadowHost); Will this break the ports with shadow dom disabled?
Shinya Kawanaka
Comment 4 2012-03-18 20:35:31 PDT
(In reply to comment #3) > (From update of attachment 132268 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132268&action=review > > Weee!!! > > > LayoutTests/fast/dom/shadow/shadow-root-js-api.html:60 > > +var youngerShadowRoot = new WebKitShadowRoot(shadowHost); > > Will this break the ports with shadow dom disabled? It should not...
Shinya Kawanaka
Comment 5 2012-03-18 20:39:35 PDT
Created attachment 132535 [details] Patch Candidate for landing
Shinya Kawanaka
Comment 6 2012-03-18 20:50:31 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 132268 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=132268&action=review > > > > Weee!!! > > > > > LayoutTests/fast/dom/shadow/shadow-root-js-api.html:60 > > > +var youngerShadowRoot = new WebKitShadowRoot(shadowHost); > > > > Will this break the ports with shadow dom disabled? > > It should not... shadow-root-js-api.html is in Skipped list in all ports except chromium now, so it should be OK.
Shinya Kawanaka
Comment 7 2012-03-18 23:17:07 PDT
Committed r111155: <http://trac.webkit.org/changeset/111155>
Note You need to log in before you can comment on or make changes to this bug.