Bug 79303 – [Supplemental] should support constants

• Component: WebCore JavaScript
• Status: RESOLVED FIXED

[Kentaro Hara]

Given that we have

    interface [Supplemental=Y] X { constant int A = 123; }

then the code generator should generate

    X::A

to refer to the constant. However, the current code generator generates Y::A instead.

[Kentaro Hara]

Created attachment 128335 [details]
Patch

[Adam Barth]

Comment on attachment 128335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128335&action=review

> Source/WebCore/bindings/scripts/CodeGenerator.pm:631
> +                push(@checks, "COMPILE_ASSERT($value == " . $constant->extendedAttributes->{"ImplementedBy"} . "::$name, ${interfaceName}Enum${name}IsWrongUseDoNotCheckConstants);\n");

Do we need to make sure the header is included in the CPP file?

[Kentaro Hara]

Created attachment 128338 [details]
patch for landing

[Kentaro Hara]

(In reply to comment #2)
> Do we need to make sure the header is included in the CPP file?

Fixed it and committed. Thanks!

[WebKit Review Bot]

Comment on attachment 128338 [details]
patch for landing

Clearing flags on attachment: 128338

Committed r108603: <http://trac.webkit.org/changeset/108603>