Bug 79300 – Add Chromium gpu_tests to the flakiness dashboard

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dave Tu]

Add Chromium gpu_tests to the flakiness dashboard.

[Dave Tu]

Created attachment 128330 [details]
Patch

[Ojan Vafai]

Comment on attachment 128330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128330&action=review

For future reference, you need to mark a patch as r? to mark it as ready for review. If you use "webkit-patch upload" it will automatically create the bug, generate the ChangeLog entry for you and upload it marked for review.

Also, if you mark it as cq? then that indicates to the reviewer that you'd like them to add it to the commit-queue once they approve the patch.

R- just for the sorting issue.

> ChangeLog:9
> +        * ../../builders.js:
> +        * ../../dashboard_base.js:

These paths aren't right. Did you create this ChangeLog entry using prepare-ChangeLog?

> Tools/TestResultServer/static-dashboards/builders.js:53
> +    'Chromium': '@DEPS - chromium.org',
> +    'ChromiumChromiumOS': '@DEPS CrOS - chromium.org',
> +    'ChromiumWebkit': '@ToT - chromium.org',
> +    'ChromiumGPU': '@DEPS - chromium.org',

Nit: can you sort these alphabetically?

[Dave Tu]

Created attachment 128340 [details]
Patch

[Dave Tu]

Thanks for the info. Sorry, I used prepare-ChangeLog and just assumed the paths were correct without checking them.

[Ojan Vafai]

(In reply to comment #4)
> Thanks for the info. Sorry, I used prepare-ChangeLog and just assumed the paths were correct without checking them.

Hm...that's a bug in prepare-ChangeLog then. Not your fault. :(

[Dave Tu]

Is there anything else I need to do to make the dashboard use the updated files?

[WebKit Review Bot]

Comment on attachment 128340 [details]
Patch

Clearing flags on attachment: 128340

Committed r108695: <http://trac.webkit.org/changeset/108695>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ojan Vafai]

(In reply to comment #6)
> Is there anything else I need to do to make the dashboard use the updated files?

Someone needs to push the new server to appengine. I won't get around to it today, but hopefully tomorrow. Also, happy to give anyone access to the server and they can push the update. :)

[Dave Tu]

(In reply to comment #9)
> (In reply to comment #6)
> > Is there anything else I need to do to make the dashboard use the updated files?
> 
> Someone needs to push the new server to appengine. I won't get around to it today, but hopefully tomorrow. Also, happy to give anyone access to the server and they can push the update. :)

Sure, I'd be glad to, if there's instructions on how to do it.