Bug 79298

Summary: [WebSocket] Remove zlib.h from WebSocketDeflater.h
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: WebCore Misc.Assignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, toyoshim, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2012-02-22 16:19:04 PST
Including zlib.h in header files introduced a bunch of zlib dependency and caused build failure unexpectedly (http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/20781). We should put zlib.h in .cpp files rather than .h files.
Attachments
Patch (9.14 KB, patch)
2012-02-22 16:27 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-02-22 16:27:03 PST
Created attachment 128326 [details] Patch
Kenichi Ishibashi
Comment 2 2012-02-22 16:29:01 PST
Hi Kent-san, Could you take a look? This change is needed to avoid adding a bunch of zlib dependency to GYP files.
Kent Tamura
Comment 3 2012-02-22 17:12:44 PST
Comment on attachment 128326 [details] Patch Looks ok.
Kenichi Ishibashi
Comment 4 2012-02-22 17:14:37 PST
Comment on attachment 128326 [details] Patch Thank you!
WebKit Review Bot
Comment 5 2012-02-22 19:44:34 PST
Comment on attachment 128326 [details] Patch Clearing flags on attachment: 128326 Committed r108600: <http://trac.webkit.org/changeset/108600>
WebKit Review Bot
Comment 6 2012-02-22 19:44:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.