Bug 79275

Summary:

[chromium] Fix CCOcclusionTracker unit test assertion

Product:

WebKit

Reporter:

Dana Jansens <danakj>

Component:

New Bugs

Assignee:

Dana Jansens <danakj>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enne, jamesr, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

75864, 79302

Attachments:

Description	Flags
Patch	none
Patch	none

Description Dana Jansens 2012-02-22 13:40:36 PST

[chromium] Fix CCOcclusionTracker unit test assertion

Comment 1 Dana Jansens 2012-02-22 13:41:12 PST

The iterators change doesn't seem to be related to this assert. I get it with and without the iterators.

Comment 2 Dana Jansens 2012-02-22 13:41:26 PST

Created attachment 128280 [details]
Patch

Was checking the surface which we already left. This is a no-no.

Comment 3 Dana Jansens 2012-02-22 13:58:19 PST

Created attachment 128284 [details]
Patch

Similar problem in CCOcclusionTrackerTest.surfaceOcclusionInScreenSpace.

And using EXPECT_TRUE/EXPECT_FALSE for bools.

Comment 4 WebKit Review Bot 2012-02-22 17:41:55 PST

Comment on attachment 128284 [details]
Patch

Clearing flags on attachment: 128284

Committed r108587: <http://trac.webkit.org/changeset/108587>

Comment 5 WebKit Review Bot 2012-02-22 17:42:00 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Tony Chang 2012-02-23 11:28:28 PST

*** Bug 79381 has been marked as a duplicate of this bug. ***