| Summary: | JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yong Li <yong.li.webkit> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, haraken, msaboff, webkit.review.bot | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yong Li
2012-02-22 12:33:17 PST
Created attachment 128271 [details]
the patch
Comment on attachment 128271 [details]
the patch
The change makes sense.
(In reply to comment #2) > (From update of attachment 128271 [details]) > The change makes sense. Thanks for reviewing! Please note that at present the WebKit svn server is down and something wrong is happening around the commit queue. If the commit fails, let us commit it again after the server recovers. Comment on attachment 128271 [details] the patch Rejecting attachment 128271 [details] from review queue. haraken@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 128271 [details] the patch Clearing flags on attachment: 128271 Committed r108649: <http://trac.webkit.org/changeset/108649> All reviewed patches have been landed. Closing bug. |