Bug 79268 - JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope()
Summary: JSString::outOfMemory() should ASSERT(isRope()) rather than !isRope()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 12:33 PST by Yong Li
Modified: 2012-02-23 11:28 PST (History)
4 users (show)

See Also:


Attachments
the patch (1.32 KB, patch)
2012-02-22 13:02 PST, Yong Li
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-02-22 12:33:17 PST
It seems JSString::outOfMemory() should ASSERT(isRope()) instead of ASSERT(!isRope())
Comment 1 Yong Li 2012-02-22 13:02:30 PST
Created attachment 128271 [details]
the patch
Comment 2 Kentaro Hara 2012-02-22 20:33:50 PST
Comment on attachment 128271 [details]
the patch

The change makes sense.
Comment 3 Yong Li 2012-02-23 06:48:39 PST
(In reply to comment #2)
> (From update of attachment 128271 [details])
> The change makes sense.

Thanks for reviewing!
Comment 4 Kentaro Hara 2012-02-23 06:52:19 PST
Please note that at present the WebKit svn server is down and something wrong is happening around the commit queue. If the commit fails, let us commit it again after the server recovers.
Comment 5 WebKit Review Bot 2012-02-23 07:42:47 PST
Comment on attachment 128271 [details]
the patch

Rejecting attachment 128271 [details] from review queue.

haraken@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 WebKit Review Bot 2012-02-23 11:28:54 PST
Comment on attachment 128271 [details]
the patch

Clearing flags on attachment: 128271

Committed r108649: <http://trac.webkit.org/changeset/108649>
Comment 7 WebKit Review Bot 2012-02-23 11:28:59 PST
All reviewed patches have been landed.  Closing bug.