Bug 79258

Summary: webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
patch for landing none

Dirk Pranke
Reported 2012-02-22 10:45:51 PST
webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
Attachments
Patch (2.50 KB, patch)
2012-02-22 10:46 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (7.48 KB, patch)
2012-02-24 14:23 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
patch for landing (9.72 KB, patch)
2012-02-24 16:29 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-02-22 10:46:08 PST
Created attachment 128246 [details] Patch
Dirk Pranke
Comment 2 2012-02-22 10:49:20 PST
Note that this patch doesn't actually work at all :) ...
Dirk Pranke
Comment 3 2012-02-24 14:23:10 PST
Created attachment 128806 [details] Patch
Dirk Pranke
Comment 4 2012-02-24 14:24:10 PST
same deal as bug 79179 ... these fuzzy matching tests are slow so I'm splitting them up so that they can be sharded better.
Ryosuke Niwa
Comment 5 2012-02-24 15:03:18 PST
Comment on attachment 128806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128806&action=review r=me provided the trailing whitespaces are restored. > Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:254 > -100000 ossy@webkit.org > +100000 ossy@webkit.org Please revert these trailing whitespace changes. The actual result contains those whitespaces and we need tests to make sure we can parse them.
Dirk Pranke
Comment 6 2012-02-24 15:06:53 PST
(In reply to comment #5) > (From update of attachment 128806 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128806&action=review > > r=me provided the trailing whitespaces are restored. > > > Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py:254 > > -100000 ossy@webkit.org > > +100000 ossy@webkit.org > > Please revert these trailing whitespace changes. The actual result contains those whitespaces and we need tests to make sure we can parse them. Hm. So you're okay with fixing the regexp? If so, then how about I change the test so that the string is a bunch of concatenated lines with quotes, like: changelog= ("foo " "bar ") so that we don't actually have trailing whitespace in the file (while keeping it in the string)? Relying on trailing whitespace in the file for test correctness is horrendous, given that the trailing whitespace may or may not even be visible in an editor :).
Dirk Pranke
Comment 7 2012-02-24 16:29:29 PST
Created attachment 128828 [details] patch for landing
Dirk Pranke
Comment 8 2012-02-24 16:31:05 PST
Committed r108868: <http://trac.webkit.org/changeset/108868>
Dirk Pranke
Comment 9 2012-02-24 16:32:24 PST
Comment on attachment 128828 [details] patch for landing (assuming that that was ok; if it wasn't, let me know and I'll fix it or roll it out).
Note You need to log in before you can comment on or make changes to this bug.