Bug 79231

Summary:

Add performance tests for the getters/setters of Element attributes

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

Tools / Tests

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

79208

Attachments:

Description	Flags
Patch	none

Kentaro Hara

Reported 2012-02-22 05:49:09 PST

We can add micro-benchmark performance tests for the getters/setters of Element attributes.

Attachments
Patch (22.18 KB, patch) 2012-02-22 06:12 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-02-22 06:04:03 PST

We can omit the performance tests for onabort, onblur, onchange, onclick, oncontextmenu, ondblclick, ondrag, ondragend, ondragenter, ondragleave, ondragover, ondragstart, ondrop, onerror, onfocus, oninput, oninvalid, onkeydown, onkeypress, onkeyup, onmousedown, onmousemove, onmouseout, onmouseover, onmouseup, onmousewheel, onscroll, onselect, onsubmit, onbeforecut, oncut, onbeforecopy, oncopy, onbeforepaste, onpaste, onreset, onsearch, onselectstart, onwebkitfullscreenchange, and onwebkitfullscreenerror, because they trace almost the same call-path as onload.

Kentaro Hara

Comment 2 2012-02-22 06:12:18 PST

Created attachment 128195 [details] Patch

Ryosuke Niwa

Comment 3 2012-02-22 06:36:58 PST

Comment on attachment 128195 [details] Patch We can not add this many tests for each getter/setter? It's gonna increase performance bot's cycle time a lot.

Note You need to log in before you can comment on or make changes to this bug.