Bug 79225

Summary:

Drop clipToImageBuffer from RenderBoxModelObject

Product:

WebKit

Reporter:

Zoltan Herczeg <zherczeg>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

darin, hyatt, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	zimmermann: review+
perf test (background image is not attached)	none

Description Zoltan Herczeg 2012-02-22 04:51:27 PST

Continue the quest to drop clipToImageBuffer from WebKit.

The bgLayer->clip() == TextFillBox is a non-standard rarely used feature. The replacement code has the same speed on Mac.

Comment 1 Zoltan Herczeg 2012-02-22 05:04:52 PST

Created attachment 128179 [details]
patch

Comment 2 Zoltan Herczeg 2012-02-22 05:06:14 PST

Created attachment 128180 [details]
perf test (background image is not attached)

Comment 3 Nikolas Zimmermann 2012-02-22 05:27:32 PST

Comment on attachment 128179 [details]
patch

Looks great, r=me.  As cr-linux is green as well, I assume this doesn't change pixel tests at all.

Comment 4 Zoltan Herczeg 2012-02-22 05:29:59 PST

Yeah. Now it is green :)

Comment 5 Zoltan Herczeg 2012-02-22 06:19:03 PST

http://trac.webkit.org/changeset/108492