Bug 79225

Summary: Drop clipToImageBuffer from RenderBoxModelObject
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: darin, hyatt, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
zimmermann: review+
perf test (background image is not attached) none

Zoltan Herczeg
Reported 2012-02-22 04:51:27 PST
Continue the quest to drop clipToImageBuffer from WebKit. The bgLayer->clip() == TextFillBox is a non-standard rarely used feature. The replacement code has the same speed on Mac.
Attachments
patch (4.45 KB, patch)
2012-02-22 05:04 PST, Zoltan Herczeg 		zimmermann: review+
DetailsFormatted DiffDiff
perf test (background image is not attached) (1.12 KB, text/plain)
2012-02-22 05:06 PST, Zoltan Herczeg 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Zoltan Herczeg
Comment 1 2012-02-22 05:04:52 PST
Created attachment 128179 [details] patch
Zoltan Herczeg
Comment 2 2012-02-22 05:06:14 PST
Created attachment 128180 [details] perf test (background image is not attached)
Nikolas Zimmermann
Comment 3 2012-02-22 05:27:32 PST
Comment on attachment 128179 [details] patch Looks great, r=me. As cr-linux is green as well, I assume this doesn't change pixel tests at all.
Zoltan Herczeg
Comment 4 2012-02-22 05:29:59 PST
Yeah. Now it is green :)
Zoltan Herczeg
Comment 5 2012-02-22 06:19:03 PST
http://trac.webkit.org/changeset/108492
Note You need to log in before you can comment on or make changes to this bug.