Bug 79209

Summary: Add performance tests for the HTMLElement.id getter and setter
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: REOPENED    
Severity: Normal CC: abarth, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79208    
Attachments:
Description Flags
Patch
none
patch for landing none

Kentaro Hara
Reported 2012-02-22 01:27:11 PST
We can add performance tests for the Element.id getter and setter. If this patch looks good, I would like to add similar performance tests for other DOM attributes.
Attachments
Patch (5.82 KB, patch)
2012-02-22 01:41 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (5.83 KB, patch)
2012-02-22 02:19 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-22 01:41:02 PST
Created attachment 128158 [details] Patch
Adam Barth
Comment 2 2012-02-22 01:43:04 PST
This is a pretty simplistic microbenchmark, but it seems useful.
Ryosuke Niwa
Comment 3 2012-02-22 02:08:55 PST
Comment on attachment 128158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128158&action=review > PerformanceTests/Bindings/dom_attributes_id_getter.html:1 > +<html> Missing DOCTYPE. > PerformanceTests/Bindings/dom_attributes_id_setter.html:1 > +<html> Ditto.
Kentaro Hara
Comment 4 2012-02-22 02:19:45 PST
Created attachment 128161 [details] patch for landing
Kentaro Hara
Comment 5 2012-02-22 02:20:25 PST
(In reply to comment #3) > (From update of attachment 128158 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=128158&action=review > > > PerformanceTests/Bindings/dom_attributes_id_getter.html:1 > > +<html> > > Missing DOCTYPE. > > > PerformanceTests/Bindings/dom_attributes_id_setter.html:1 > > +<html> > > Ditto. Fixed. Thanks.
WebKit Review Bot
Comment 6 2012-02-22 03:20:56 PST
Comment on attachment 128161 [details] patch for landing Clearing flags on attachment: 128161 Committed r108477: <http://trac.webkit.org/changeset/108477>
Kentaro Hara
Comment 7 2012-02-24 06:03:12 PST
Reverted r108477 for reason: The perf tests committed in r108748 covers the perf tests committed in r108477. So I'll roll out r108477. Committed r108782: <http://trac.webkit.org/changeset/108782>
Note You need to log in before you can comment on or make changes to this bug.