Bug 79174

Summary: Early-out in Region::unite() for adding an empty region.
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, backer, jamesr, piman, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dana Jansens
Reported 2012-02-21 18:05:26 PST
Early-out in Region::unite() for adding an empty region.
Attachments
Patch (1.25 KB, patch)
2012-02-21 18:06 PST, Dana Jansens 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-02-21 18:06:27 PST
Created attachment 128099 [details] Patch We've noticed that unite() with an empty region ends up making a copy of the entire current Region, and may also add an empty rect in the return from rects(). This early out saves a lot of work for this case, and fixes Region uniqueness for the given area it covers.
WebKit Review Bot
Comment 2 2012-02-21 18:58:39 PST
Comment on attachment 128099 [details] Patch Clearing flags on attachment: 128099 Committed r108433: <http://trac.webkit.org/changeset/108433>
WebKit Review Bot
Comment 3 2012-02-21 18:58:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.