Bug 79153

Summary: Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions
Product: WebKit Reporter: Peter Rybin <prybin>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
old InspectorBackendDispatcher.h
none
old InspectorFrontend.h
none
old InspectorFrontend.cpp
none
new InspectorBackendDispatcher.h
none
new InspctorFrontend.h
none
new InspectorFrontend.cpp
none
Patch none

Description Peter Rybin 2012-02-21 15:23:15 PST 
Generator still has some resemblance to a neural network, meaning that it has some irregular structures that were "trained" to generate the right output for a certain input.

Replace such structures with more regular ones and make sure its uniform for all types.
Comment 1 Peter Rybin 2012-02-21 15:48:37 PST 
Created attachment 128063 [details]
Patch
Comment 2 Peter Rybin 2012-02-21 16:16:24 PST 
Created attachment 128072 [details]
old InspectorBackendDispatcher.h
Comment 3 Peter Rybin 2012-02-21 16:16:58 PST 
Created attachment 128073 [details]
old InspectorFrontend.h
Comment 4 Peter Rybin 2012-02-21 16:17:18 PST 
Created attachment 128074 [details]
old InspectorFrontend.cpp
Comment 5 Peter Rybin 2012-02-21 16:18:25 PST 
Created attachment 128075 [details]
new InspectorBackendDispatcher.h
Comment 6 Peter Rybin 2012-02-21 16:18:45 PST 
Created attachment 128076 [details]
new InspctorFrontend.h
Comment 7 Peter Rybin 2012-02-21 16:19:15 PST 
Created attachment 128077 [details]
new InspectorFrontend.cpp
Comment 8 Yury Semikhatsky 2012-02-22 03:56:42 PST 
Comment on attachment 128063 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=128063&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:533
> +    String* sourceMapURLParam = sourceMapURL.isNull() ? 0 : & sourceMapURL;

style nit: remove extra space between & and sourceMapURL
Comment 9 Peter Rybin 2012-02-22 06:15:33 PST 
Created attachment 128197 [details]
Patch
Comment 10 Yury Semikhatsky 2012-02-22 07:05:03 PST 
Comment on attachment 128197 [details]
Patch

Clearing flags on attachment: 128197

Committed r108496: <http://trac.webkit.org/changeset/108496>
Comment 11 Yury Semikhatsky 2012-02-22 07:05:13 PST 
All reviewed patches have been landed.  Closing bug.