Bug 79127

Summary: Remove obsolete float comparison FIXMEs
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, leviw, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2012-02-21 10:51:28 PST
Back when we where still considering using floating point units for the layout tree we added a bunch of FIXME comments in places where we would have to change comparison to use epsilon. Those comments are now obsolete as we no longer intend to use float point.
Attachments
Patch (7.86 KB, patch)
2012-02-21 10:55 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-02-21 10:55:16 PST
Created attachment 128000 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-21 10:58:27 PST
Comment on attachment 128000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128000&action=review OK. > Source/WebCore/rendering/RenderBlock.cpp:1520 > repaintRectangle(repaintRect); // We need to do a partial repaint of our content. Does this need rounding now?
Emil A Eklund
Comment 3 2012-02-21 11:21:13 PST
Comment on attachment 128000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128000&action=review >> Source/WebCore/rendering/RenderBlock.cpp:1520 >> repaintRectangle(repaintRect); // We need to do a partial repaint of our content. > > Does this need rounding now? Nope, repaintRectangle takes a LayoutRect.
Emil A Eklund
Comment 4 2012-02-21 11:32:42 PST
Committed r108377: <http://trac.webkit.org/changeset/108377>
Note You need to log in before you can comment on or make changes to this bug.