Bug 79121

Summary: Move PropertySetCSSStyleDeclaration to a file of its own
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, kling, koivisto, pnormand, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+, pnormand: commit-queue-
now with header included
pnormand: commit-queue-
with gtk build file webkit.review.bot: commit-queue-

Description Antti Koivisto 2012-02-21 09:18:25 PST
From StylePropertySet.cpp
Comment 1 Antti Koivisto 2012-02-21 09:22:01 PST
Created attachment 127984 [details]
patch
Comment 2 Antti Koivisto 2012-02-21 09:23:02 PST
"StylePropertySetCSSStyleDeclaration" would be more consistent but repeating "Style" looks bit silly.
Comment 3 Philippe Normand 2012-02-21 09:28:17 PST
Comment on attachment 127984 [details]
patch

Attachment 127984 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11559159
Comment 4 Early Warning System Bot 2012-02-21 09:29:28 PST
Comment on attachment 127984 [details]
patch

Attachment 127984 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11520167
Comment 5 Andreas Kling 2012-02-21 09:30:59 PST
Comment on attachment 127984 [details]
patch

rs=me
Comment 6 Antti Koivisto 2012-02-21 09:32:21 PST
Created attachment 127986 [details]
now with header included
Comment 7 Philippe Normand 2012-02-21 09:36:49 PST
Comment on attachment 127986 [details]
now with header included

Attachment 127986 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11562149
Comment 8 Antti Koivisto 2012-02-21 09:39:51 PST
Created attachment 127988 [details]
with gtk build file
Comment 9 WebKit Review Bot 2012-02-21 10:26:59 PST
Comment on attachment 127988 [details]
with gtk build file

Attachment 127988 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11557154
Comment 10 Antti Koivisto 2012-02-21 10:38:54 PST
http://trac.webkit.org/changeset/108370

(with Chromium build file fix)