Bug 79116

Summary:

Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Pavel Feldman

Reported 2012-02-21 08:41:25 PST

Patch to follow.

Attachments
Patch (29.22 KB, patch) 2012-02-21 08:43 PST, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-02-21 08:43:19 PST

Created attachment 127979 [details] Patch

Yury Semikhatsky

Comment 2 2012-02-22 04:05:01 PST

Comment on attachment 127979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127979&action=review > Source/WebCore/dom/ScriptedAnimationController.cpp:88 > + InspectorInstrumentation::didRequestAnimationFrameCallback(m_document, id); didRequestAnimationFrameCallback -> didRequestAnimationFrame ? > Source/WebCore/inspector/InspectorInstrumentation.cpp:996 > +void InspectorInstrumentation::didRequestAnimationFrameCallbackImpl(InstrumentingAgents* instrumentingAgents, int callbackId) didRequestAnimationFrameCallbackImpl -> didRequestAnimationFrameImpl

Pavel Feldman

Comment 3 2012-02-22 05:12:49 PST

Committed r108486: <http://trac.webkit.org/changeset/108486>

Csaba Osztrogonác

Comment 4 2012-02-22 05:19:08 PST

It broke (at least) the Qt build: ../../../../Source/WebCore/inspector/InspectorController.cpp:72:36: error: base/debug/stack_trace.h: No such file or directory

Csaba Osztrogonác

Comment 5 2012-02-22 09:29:36 PST

fix landed in http://trac.webkit.org/changeset/108488

Note You need to log in before you can comment on or make changes to this bug.