Summary: | [chromium] Plumb extensionGroup into didCreateScriptContext(). | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Kozianski <koz> | ||||||
Component: | New Bugs | Assignee: | James Kozianski <koz> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, fishd, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
James Kozianski
2012-02-20 20:29:41 PST
Created attachment 127906 [details]
Patch
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Comment on attachment 127906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review > Source/WebKit/chromium/public/WebFrameClient.h:300 > + virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { } Is your plan to land a Chromium change ahead of this change that implements this new method signature? (In reply to comment #3) > (From update of attachment 127906 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review > > > Source/WebKit/chromium/public/WebFrameClient.h:300 > > + virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { } > > Is your plan to land a Chromium change ahead of this change that implements this new method signature? Yep, that's right. Created attachment 129120 [details]
Patch for landing
Comment on attachment 129120 [details] Patch for landing Clearing flags on attachment: 129120 Committed r109064: <http://trac.webkit.org/changeset/109064> All reviewed patches have been landed. Closing bug. |