Bug 79072

Summary: [chromium] Plumb extensionGroup into didCreateScriptContext().
Product: WebKit Reporter: James Kozianski <koz>
Component: New BugsAssignee: James Kozianski <koz>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, fishd, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

James Kozianski
Reported 2012-02-20 20:29:41 PST
[chromium] Plumb extensionGroup into didCreateScriptContext().
Attachments
Patch (7.34 KB, patch)
2012-02-20 20:30 PST, James Kozianski 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.40 KB, patch)
2012-02-27 16:01 PST, James Kozianski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Kozianski
Comment 1 2012-02-20 20:30:40 PST
Created attachment 127906 [details] Patch
WebKit Commit Bot
Comment 2 2012-02-23 19:19:33 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2012-02-23 22:37:42 PST
Comment on attachment 127906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review > Source/WebKit/chromium/public/WebFrameClient.h:300 > + virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { } Is your plan to land a Chromium change ahead of this change that implements this new method signature?
James Kozianski
Comment 4 2012-02-26 18:34:54 PST
(In reply to comment #3) > (From update of attachment 127906 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127906&action=review > > > Source/WebKit/chromium/public/WebFrameClient.h:300 > > + virtual void didCreateScriptContext(WebFrame*, v8::Handle<v8::Context>, int extensionGroup, int worldId) { } > > Is your plan to land a Chromium change ahead of this change that implements this new method signature? Yep, that's right.
James Kozianski
Comment 5 2012-02-27 16:01:31 PST
Created attachment 129120 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-02-27 19:31:19 PST
Comment on attachment 129120 [details] Patch for landing Clearing flags on attachment: 129120 Committed r109064: <http://trac.webkit.org/changeset/109064>
WebKit Review Bot
Comment 7 2012-02-27 19:31:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.