Bug 79064

Summary: Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, ian, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
none
Patch none

Description Kentaro Hara 2012-02-20 18:22:22 PST 
[TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].

But as far as I read the spec (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup), there is no statement about what value should be returned when HTMLMediaElement.mediaGroup is not yet initialized. In particular, there is no statement that says "null should be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, I think that instead of fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense. Removing [TreatReturnedNullStringAsNull] does not change the current behavior.
Comment 1 Kentaro Hara 2012-02-20 18:25:36 PST 
Created attachment 127889 [details]
Patch
Comment 2 Adam Barth 2012-02-20 20:08:17 PST 
Comment on attachment 127889 [details]
Patch

Can we add a test that verifies this behavior?
Comment 3 Kentaro Hara 2012-02-20 20:30:33 PST 
Created attachment 127905 [details]
Patch
Comment 4 Kentaro Hara 2012-02-20 20:31:56 PST 
(In reply to comment #2)
> (From update of attachment 127889 [details])
> Can we add a test that verifies this behavior?

media/media-controller.html already has the test:

    testExpected("video.mediaGroup", "");

I added "Test: media/media-controller.html (No change in the test result)" to ChangeLog.
Comment 5 Hajime Morrita 2012-02-20 21:37:39 PST 
Comment on attachment 127905 [details]
Patch

I'd like to see green cr-linux.
Comment 6 Hajime Morrita 2012-02-20 21:38:16 PST 
Also, please take care of ChangeLog diff crash.
Comment 7 WebKit Review Bot 2012-02-20 22:23:42 PST 
Comment on attachment 127905 [details]
Patch

Clearing flags on attachment: 127905

Committed r108305: <http://trac.webkit.org/changeset/108305>
Comment 8 WebKit Review Bot 2012-02-20 22:23:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Ian 'Hixie' Hickson 2012-02-21 12:21:18 PST 
The mediaGroup IDL attribute on media elements must reflect the mediagroup content attribute. It's always initialised. There's no concept of it not being initialised.
Comment 10 Kentaro Hara 2012-02-21 13:58:00 PST 
(In reply to comment #9)
> The mediaGroup IDL attribute on media elements must reflect the mediagroup content attribute. It's always initialised. There's no concept of it not being initialised.

Hixie: Thanks for the clarification!