Bug 79050

Summary: MEDIA_STREAM should be implemented as a PageSupplement.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: PlatformAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, pnormand, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78440    
Attachments:
Description Flags
Patch
none
Patch abarth: review+, morrita: commit-queue-

Hajime Morrita
Reported 2012-02-20 16:18:41 PST
UserMediaClient should be extracted as a PageSupplement to eliminate MEDIA_STREAM ifdef in Page.h.
Attachments
Patch (19.51 KB, patch)
2012-02-20 18:30 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (20.24 KB, patch)
2012-02-20 19:35 PST, Hajime Morrita 		abarth: review+
morrita: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2012-02-20 18:30:13 PST
Created attachment 127891 [details] Patch
Philippe Normand
Comment 2 2012-02-20 18:51:16 PST
Comment on attachment 127891 [details] Patch Attachment 127891 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11548449
Hajime Morrita
Comment 3 2012-02-20 19:35:45 PST
Created attachment 127899 [details] Patch
Hajime Morrita
Comment 4 2012-02-20 19:36:03 PST
Hi Adam, could you take a look? This should be easy. Note that there are some other ifdefs I don't touch in this change. I expect They would be handled by the IDL supplemental refactoring.
Adam Barth
Comment 5 2012-02-21 15:54:52 PST
Comment on attachment 127899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127899&action=review > Source/WebCore/mediastream/UserMediaController.cpp:34 > + DEFINE_STATIC_LOCAL(AtomicString, name, ("userMedia")); I would have called this UserMediaController to match the class name. (Just to make sure there are no collisions.)
Hajime Morrita
Comment 6 2012-02-21 19:56:57 PST
Committed r108437: <http://trac.webkit.org/changeset/108437>
Note You need to log in before you can comment on or make changes to this bug.