Bug 79030

Summary: Web Inspector: add "show paint rectangles" setting.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Pavel Feldman
Reported 2012-02-20 06:39:08 PST
It is often useful to see what rectangles are being repainted. Adding a setting that allows toggling it.
Attachments
Patch (46.30 KB, patch)
2012-02-20 06:48 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (22.47 KB, patch)
2012-02-21 01:51 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-02-20 06:48:37 PST
Created attachment 127817 [details] Patch
Timothy Hatcher
Comment 2 2012-02-20 10:49:18 PST
Why does the client need to do this? Same reason the client does node highlights?
Pavel Feldman
Comment 3 2012-02-20 11:02:41 PST
(In reply to comment #2) > Why does the client need to do this? Same reason the client does node highlights? I was going to expose the feature that was already there in Chrome first. I will try upstreaming it in case it sticks. Here is what it looks like in Chrome today: http://www.youtube.com/watch?v=Ea41RdQ1oFQ&t=1m30s
Timothy Hatcher
Comment 4 2012-02-20 11:28:19 PST
Hovering in the Timeline seems more interesting. That is a different API right?
Pavel Feldman
Comment 5 2012-02-20 21:35:17 PST
Hovering in the Timeline is using data collected while instrumenting to highlight regions on the screen, so it is different. To your client concern, I'll rework this change to upstream Chrome's debug paint rects all in one change - should not be much work.
Pavel Feldman
Comment 6 2012-02-21 01:51:20 PST
Created attachment 127939 [details] Patch
Pavel Feldman
Comment 7 2012-02-21 03:28:34 PST
Committed r108330: <http://trac.webkit.org/changeset/108330>
Note You need to log in before you can comment on or make changes to this bug.