Bug 79024

Summary: Web Inspector: clicking empty space should not re-enter edit mode
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Pavel Feldman 2012-02-20 03:31:29 PST
1. Click in the emtpy element.style { } rule's whitespace
2. Editing begins
3. Click on the white space again

Expected: editing ends
Actual: edit mode is re-entered
Comment 1 Pavel Feldman 2012-02-20 03:33:32 PST
Created attachment 127799 [details]
Patch
Comment 2 Pavel Feldman 2012-02-20 03:55:18 PST
Created attachment 127803 [details]
Patch
Comment 3 Alexander Pavlov (apavlov) 2012-02-20 04:08:46 PST
Comment on attachment 127803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127803&action=review

> Source/WebCore/ChangeLog:1
>  2012-02-20  pfeldman@chomium.org  <pavel.feldman@gmail.com>

Bad user data (and a mistype in the chromium.org email)
Comment 4 Pavel Feldman 2012-02-20 04:10:50 PST
Comment on attachment 127803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127803&action=review

>> Source/WebCore/ChangeLog:1
>>  2012-02-20  pfeldman@chomium.org  <pavel.feldman@gmail.com>
> 
> Bad user data (and a mistype in the chromium.org email)

Blame webkit-patch...
Comment 5 Pavel Feldman 2012-02-20 04:15:10 PST
Created attachment 127804 [details]
Patch
Comment 6 Pavel Feldman 2012-02-21 03:32:26 PST
Comment on attachment 127804 [details]
Patch

Clearing flags on attachment: 127804

Committed r108332: <http://trac.webkit.org/changeset/108332>
Comment 7 Pavel Feldman 2012-02-21 03:32:34 PST
All reviewed patches have been landed.  Closing bug.